AKMC-113: Add SADB MariaDB code for working with MySQL BINARY fields #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dccutrig
reviewed
Nov 23, 2021
| @@ -231,10 +243,45 @@ static int32 parse_sa_from_mysql_query(char* query, SecurityAssociation_t** secu | |||
|
|
|||
| return status; | |||
| } | |||
| static int32 convert_hexstring_to_byte_array(char* source_str, uint8* dest_buffer) | |||
There was a problem hiding this comment.
I like this function - should we consider moving some of these helpers like this to a utils file / directory for access in other files e.g. crypto_util/src?
There was a problem hiding this comment.
I don't think the MariaDB/mysql source code should depend on the crypto_util source tree at this time... So far, everything under crypto_util are test & related helper applications/libraries, not things we expect end-users to use.
There was a problem hiding this comment.
This is an intermediary PR, there is still mysql integration work to do... since this is the only comment and the function can be refactored when needed, I'm going to proceed with the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.